Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of --add-opens workaround, and turn it into a modifier shipped with running-ng #130

Closed
caizixian opened this issue Nov 20, 2023 · 1 comment · Fixed by #134
Closed

Comments

@caizixian
Copy link
Member

It's currently not sufficient.

  h2o21:
    type: JVMArg
    val: "-Dsys.ai.h2o.debug.allowJavaVersions=21 --add-opens java.base/java.lang=ALL-UNNAMED"
    includes:
      dacapochopin-rc5:
        - h2o
  cassandra21:
    type: JVMArg
    val: "-Djava.security.manager=allow --add-exports java.base/sun.nio.ch=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED --add-opens java.base/sun.nio.ch=ALL-UNNAMED"
    includes:
      dacapochopin-rc5:
        - cassandra
  trades21:
    type: JVMArg
    val: "--add-opens java.base/java.util=ALL-UNNAMED"
    includes:
      dacapochopin-rc5:
        - tradebeans
        - tradesoap
@caizixian
Copy link
Member Author

caizixian commented Nov 20, 2023

Partially resolved in #131. #114 is probably not needed anymore. Encoding such complicated workaround in the code is a bad idea, and it cannot be easily customized by users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant