ZOOKEEPER-2108 ZOOKEEPER-3908 ZOOKEEPER-4491: fixing zktreeutil, adding ssl support #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng ssl support Currently, zktreeutil tool **doesn't compile/work**. This PR brings back `zktreeutil` to life and adds SSL support to connect to TLS enabled ZooKeeper server. **Following are the issues fixed with this PR.** 1) [ZOOKEEPER-2108](https://issues.apache.org/jira/browse/ZOOKEEPER-2108) **(Compilation error in ZkAdaptor.cc with GCC 4.7 or later)** The compilation error in `ZkAdaptor.cc` is fixed by including the header file. Also, updated the `ZOOKEEPER_PATH` in `configure.ac` 2) [ZOOKEEPER-3908](https://issues.apache.org/jira/browse/ZOOKEEPER-3908) **(zktreeutil multiple issues)** Fixed the issues reported in this ticket. 3) [ZOOKEEPER-4491](https://issues.apache.org/jira/browse/ZOOKEEPER-4491) **(Adding SSL support to Zktreeutil)** - Adds the SSL support to `zktreeutil` to talk to TLS enabled ZooKeeper server, If SSL params are passed, invoke `zookeeper_init_ssl` method to connect the server. - Used the same OpenSSL library auto-detect code from the c-client `configure.ac` (apache#1159) Attached the testing log. [zktreeutil_testing_connection.txt](https://github.com/apache/zookeeper/files/8585349/zktreeutil_testing_connection.txt) Author: Manu Mathew <manu.mathew@netapp.com> Author: mathewmanu <manmathew@cs.stonybrook.edu> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1870 from mathew-manu/ZOOKEEPER-4491
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, zktreeutil tool doesn't compile/work. This PR brings back
zktreeutilto life and adds SSL support to connect to TLS enabled ZooKeeper server.Following are the issues fixed with this PR.
ZOOKEEPER-2108 (Compilation error in ZkAdaptor.cc with GCC 4.7 or later)
The compilation error in
ZkAdaptor.ccis fixed by including the header file. Also, updated theZOOKEEPER_PATHinconfigure.acZOOKEEPER-3908 (zktreeutil multiple issues)
Fixed the issues reported in this ticket.
ZOOKEEPER-4491 (Adding SSL support to Zktreeutil)
Adds the SSL support to
zktreeutilto talk to TLS enabled ZooKeeper server, If SSL params are passed, invokezookeeper_init_sslmethod to connect the server.Used the same OpenSSL library auto-detect code from the c-client
configure.ac(ZOOKEEPER-3630: Autodetection of openssl during ZooKeeper C client build apache/zookeeper#1159)Attached the testing log.
zktreeutil_testing_connection.txt
Author: Manu Mathew manu.mathew@netapp.com
Author: mathewmanu manmathew@cs.stonybrook.edu
Reviewers: Enrico Olivelli eolivelli@apache.org, Mate Szalay-Beko symat@apache.org
Closes apache#1870 from mathew-manu/ZOOKEEPER-4491