fix browse rows query error handling + boolean filter value (close ha…

…sura#2421) (hasura#2440)
anurag · Jun 28, 2019 · c85986c · c85986c
1 parent aae6887
commit c85986c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/console/src/components/Services/Data/TableBrowseRows/FilterActions.js b/console/src/components/Services/Data/TableBrowseRows/FilterActions.js
@@ -72,7 +72,11 @@ const runQuery = tableSchema => {
         return w;
       }
       if (colType === 'boolean') {
-        w[colName][opName] = val === 'true' ? true : false;
+        if (val === 'true') {
+          w[colName][opName] = true;
+        } else if (val === 'false') {
+          w[colName][opName] = false;
+        }
       }
       return w;
     });

diff --git a/console/src/components/Services/Data/TableBrowseRows/ViewActions.js b/console/src/components/Services/Data/TableBrowseRows/ViewActions.js
@@ -12,7 +12,6 @@ import dataHeaders from '../Common/Headers';
 /* ****************** View actions *************/
 const V_SET_DEFAULTS = 'ViewTable/V_SET_DEFAULTS';
 const V_REQUEST_SUCCESS = 'ViewTable/V_REQUEST_SUCCESS';
-const V_REQUEST_ERROR = 'ViewTable/V_REQUEST_ERROR';
 const V_EXPAND_REL = 'ViewTable/V_EXPAND_REL';
 const V_CLOSE_REL = 'ViewTable/V_CLOSE_REL';
 const V_SET_ACTIVE = 'ViewTable/V_SET_ACTIVE';
@@ -101,7 +100,12 @@ const vMakeRequest = () => {
         }
       },
       error => {
-        dispatch({ type: V_REQUEST_ERROR, data: error });
+        Promise.all([
+          dispatch(
+            showErrorNotification('Browse query failed!', error.error, error)
+          ),
+          dispatch({ type: V_REQUEST_PROGRESS, data: false }),
+        ]);
       }
     );
   };