Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing the wrong PR numbers #1055

Closed
Showrin opened this issue May 11, 2021 · 5 comments
Closed

Showing the wrong PR numbers #1055

Showrin opened this issue May 11, 2021 · 5 comments

Comments

@Showrin
Copy link

Showrin commented May 11, 2021

Describe the bug
I have 140 closed PRs and 1 open or. But it's showing only 47 prs in the Total PR field. Also, I put true in the count_private param. Here's the link that I used: https://github-readme-stats.vercel.app/api?username=showrin&count_private=true
And here's my profile link: https://github.com/Showrin
Is it showing the PR of this year only? If it is, then I think there should an identifier with the field like Total PR (2021).

Expected behavior
It should show 141 in the Total PR field.

@florianbussmann
Copy link
Contributor

The expected behavior is to show the total number of Pull Requests authored by you and I can at least confirm that it works for me.
Looking at your profile I can see 47 public pull requests on GitHub. You can check it here https://github.com/pulls?q=is%3Apr+author%3AShowrin+is%3Apublic

image

So I guess the missing pull requests are on private repositories or where do you get the total number of 141? https://github.com/pulls?q=is%3Apr+author%3AShowrin+is%3Aprivate

@Showrin
Copy link
Author

Showrin commented May 11, 2021

@florianbussmann Thanks so much for your reply. Yes, you are right. I have 94 private and 47 public repo. Shouldn't it show all the pr as I am setting count_private to true?

@florianbussmann
Copy link
Contributor

@Showrin I just tried it myself and unfortunately count_private has no effect in this case.

However I get the total PR count, including those from private repos, on my own instance of github-readme-stats which uses a personal access token of my account that can read my private repositories. If you want to do the same you can find the base instructions to do this here: https://github.com/anuraghazra/github-readme-stats#deploy-on-your-own-vercel-instance

Contrary to the instructions, PRs from private repos still didn't show up until I added the repo scope as shown below

image

**Q:** How to count private stats?
> **Ans:** We can only count private commits & we cannot access any other private info of any users, so it's not possible. only way is to deploy on your own instance & use your own PAT (Personal Access Token)

@Showrin
Copy link
Author

Showrin commented May 11, 2021

@florianbussmann Great man, Thanks so much. I deployed it on my own vercel instance and It worked for me. 🚀 🚀

I think we can close this issue. Thanks again.

@anuraghazra
Copy link
Owner

Great! thanks @florianbussmann for the clarification. And for helping on other issues too. :)

Closing it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants