Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow render in Safari sometimes (random) #120

Closed
eddiejaoude opened this issue Jul 20, 2020 · 11 comments
Closed

Slow render in Safari sometimes (random) #120

eddiejaoude opened this issue Jul 20, 2020 · 11 comments
Labels
bug Something isn't working. design Issues, fixes related to design or alignments. help wanted Extra attention is needed. stale Issue is marked as stale.

Comments

@eddiejaoude
Copy link

eddiejaoude commented Jul 20, 2020

Mac Safari has rendering issues

Screenshot 2020-07-20 20 08 18

@anuraghazra
Copy link
Owner

anuraghazra commented Jul 20, 2020

Hi @eddiejaoude thanks for reporting the issues, I'll look into this ASAP.

If you provide me exact system information of your setup then I could debug this with ease (eg: Mac OS, browser versions)

Thanks!

could be related to #59

@anuraghazra anuraghazra added bug Something isn't working. design Issues, fixes related to design or alignments. labels Jul 20, 2020
@eddiejaoude
Copy link
Author

I think you are right, it looks very similar and my versions are similar too.

Mac 15.15.5
Safari 13.1.1

@anuraghazra
Copy link
Owner

@filiptronicek @edisonlee55 maybe you guys can help us debug this? that would be very helpful. thanks! ❤️

@filiptronicek
Copy link
Contributor

@anuraghazra I was trying to reproduce it, but have no luck. I am trying on Catalina Safari 13.1.1 so that shouldn't be the problem. @eddiejaoude can you please provide further information (or try on a different machine) on how the loading looks like. Thanks!

P.S. might be because of some in-browser issue, which we cannot fix. Just throwing it in here.

@anuraghazra
Copy link
Owner

anuraghazra commented Jul 21, 2020

@anuraghazra I was trying to reproduce it, but have no luck. I am trying on Catalina Safari 13.1.1 so that shouldn't be the problem. @eddiejaoude can you please provide further information (or try on a different machine) on how the loading looks like. Thanks!

P.S. might be because of some in-browser issue, which we cannot fix. Just throwing it in here.

The most straightforward solution would be to disable the animations completely. but the issue is we cannot detect the User-Agent from the server because User agent will be "camo" (Github's UA)

Maybe we could try this? seems legit
https://stackoverflow.com/questions/16348489/is-there-a-css-hack-for-safari-only-not-chrome
https://solvit.io/bcf61b6
@filiptronicek can you check out these CSS hacks and see which works?

@filiptronicek
Copy link
Contributor

@anuraghazra I was trying to reproduce it, but have no luck. I am trying on Catalina Safari 13.1.1 so that shouldn't be the problem. @eddiejaoude can you please provide further information (or try on a different machine) on how the loading looks like. Thanks!
P.S. might be because of some in-browser issue, which we cannot fix. Just throwing it in here.

The most straightforward solution would be to disable the animations completely. but the issue is we cannot detect the User-Agent from the server because User-agent will be "camo" (Github's UA)

Maybe we could try this? seems legit
https://stackoverflow.com/questions/16348489/is-there-a-css-hack-for-safari-only-not-chrome

Yeah.... so, I think we, unfortunately, cannot use that, we cannot pass any styling info (as previously noted on #79.) the important thing is now to get a hold of what it looks like, see if anyone has this issue also and then either

  1. do it ourselves
  2. contact Apple and see what we can do

@filiptronicek
Copy link
Contributor

#79 (comment)

@anuraghazra
Copy link
Owner

anuraghazra commented Jul 21, 2020

Yeah.... so, I think we, unfortunately, cannot use that, we cannot pass any styling info (as previously noted on #79.) the important thing is now to get a hold of what it looks like, see if anyone has this issue also and then either

  1. do it ourselves
  2. contact Apple and see what we can do

I see but i'm already using CSS & CSS Keyframes i'm pretty sure we can use media queries because github serves the image as SVG (and it does render the CSS with it) so i think it should work. and in #79 (comment) the author is refering to tag media queries it does not work because github wont render the picture tag,

Oh wait @filiptronicek i think you already tried that right? #79 (comment)

@filiptronicek
Copy link
Contributor

Yeah.... so, I think we, unfortunately, cannot use that, we cannot pass any styling info (as previously noted on #79.) the important thing is now to get a hold of what it looks like, see if anyone has this issue also and then either

  1. do it ourselves
  1. contact Apple and see what we can do

I see but i'm already using CSS & CSS Keyframes i'm pretty sure we can use media queries because github serves the image as SVG (and it does render the CSS with it) so i think it should work. and in #79 (comment) the author is refering to tag media queries it does not work because github wont render the picture tag,

Oh wait @filiptronicek i think you already tried that right? #79 (comment)

As I remember doing it, I just did the plain HTML Img with the media=prefers color scheme thing, didn't try the svg styles yet

@eddiejaoude
Copy link
Author

Sorry I should have said, it is random, it sometimes works and sometimes does not 🤦‍♂️ - it makes it very hard to debug and reproduce consistently 😞

@anuraghazra anuraghazra added the help wanted Extra attention is needed. label Jul 24, 2020
@stale
Copy link

stale bot commented Dec 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue is marked as stale. label Dec 6, 2020
@stale stale bot closed this as completed Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. design Issues, fixes related to design or alignments. help wanted Extra attention is needed. stale Issue is marked as stale.
Projects
None yet
Development

No branches or pull requests

3 participants