Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top contributions card #2027

Open
HwangTaehyun opened this issue Sep 15, 2022 · 8 comments
Open

Top contributions card #2027

HwangTaehyun opened this issue Sep 15, 2022 · 8 comments
Labels
enhancement New feature or request.

Comments

@HwangTaehyun
Copy link
Contributor

HwangTaehyun commented Sep 15, 2022

Is your feature request related to a problem? Please describe.

  • It would be nice to have a card showing GitHub contributor stats so that we can show at a glance which open sources we are interested in.

Taehyun's GitHub Contributor stats

Describe the solution you'd like

@rickstaa
Copy link
Collaborator

@HwangTaehyun Thanks for bringing your project to our attention, and great to see that you did your project in TS. 🚀 Would be great to migrate github-readme-stats over to typescript in the future.

I like your idea and think it is within the scope of the github-readme-stats repository. I would love to add it to the github-readme-stats repository if you are interested. Nevertheless, I have to check with @anuraghazra if he thinks this is a good idea since we are already rate-limited by GitHub. I proposed #1867 to fix this, but we still have to decide on this issue.

@rickstaa rickstaa added the enhancement New feature or request. label Sep 16, 2022
@rickstaa rickstaa changed the title Open-source for GitHub contributor stats (https://github.com/HwangTaehyun/github-contributor-stats) Top contributions card Sep 16, 2022
@HwangTaehyun
Copy link
Contributor Author

@rickstaa Oh, I'm delighted to hear that! Thanks for your attention to this work and I'm looking forward to hearing from you and @anuraghazra!

@anuraghazra
Copy link
Owner

The name kind of is misleading tho.

is it actually "top" or "latest"?
It looks the most latest organizations I've contributed to.

@rickstaa
Copy link
Collaborator

rickstaa commented Oct 3, 2022

The name kind of is misleading tho.

is it "top" or "latest"? It looks like the most latest organizations I've contributed to.

I agree with @anuraghazra. Based on your code you are currently showing the latest contributions. A card I could see within the GRS family would one that would show your top contributions to other repositories. Meaning the repositories to which you made the most PR and commits. I am not sure if we can directly get this information using the current GraphQL API (see repositoryconnection). I saw that some people could retrieve this information using two Graphql calls (see https://stackoverflow.com/questions/54757319/githubs-graphql-api-how-can-i-get-all-of-the-commits-ive-contributed-to-a-par).

@HwangTaehyun
Copy link
Contributor Author

I intended to show all contributor stats with ranking order and some customized hide settings. I refer to your link and test it. However, maybe there are some problems when showing all contributions because GitHub told me that they offer only within 3-5 years contributions for graphql API when I asked.

@rickstaa
Copy link
Collaborator

rickstaa commented Oct 3, 2022

@HwangTaehyun Ah, in that case, I think showing the top contributions might not yet possible given the current graphQL API. As a user, I would be most interested in showing my top contributions, not my latest ones, since these are already found in the GitHub contribution widget.

image

I think your card is very well coded, and you did a great job creating a unique card that will certainly appeal to some GRS users. For now, though, I think it is better to keep it on https://gihub.com/HwangTaehyun/github-contributor-stats until GraphQL makes it possible to show the top 5 contributions a user has made.

@HwangTaehyun
Copy link
Contributor Author

HwangTaehyun commented Oct 3, 2022

I want to know what the meaning of top contribution. Repo that I contributed by many PRs or Top stars repo though I contributed only once.
Currently, I intended to show latter repos!

@rickstaa
Copy link
Collaborator

rickstaa commented Oct 3, 2022

@HwangTaehyun Ah, good point! I now understand your intentions with the card and why there is a score behind the repo. 😄 The card I had in mind would check all the repositories a user has contributed to, filter them according to the number of PR and list them from the most PR to the least. This way, a user can show in which repositories he is a frequent contributor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

3 participants