Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Vertical Orientation #70

Closed
nathanchu opened this issue Jul 15, 2020 · 5 comments
Closed

[Feature Request] Vertical Orientation #70

nathanchu opened this issue Jul 15, 2020 · 5 comments
Labels
design Issues, fixes related to design or alignments. stale Issue is marked as stale.

Comments

@nathanchu
Copy link
Contributor

There should be a way to change the orientation of the image. For example, this jsFiddle.

@filiptronicek
Copy link
Contributor

This looks very good, but I think it has a fairly limited use case. Some things to consider:

  • what could be stacked next to it (it would have to be similar height, and if it was another GitHub readme widget, why)
  • how it will look, if stacked on mobile.

@anuraghazra anuraghazra added design Issues, fixes related to design or alignments. feature labels Jul 15, 2020
@anuraghazra
Copy link
Owner

Thanks for requesting the feature @nthnchu i'll see what i can do

@nathanchu
Copy link
Contributor Author

  • what could be stacked next to it (it would have to be similar height, and if it was another GitHub readme widget, why)

I was thinking text could be next to it, so the widget(s) would look like a sidebar. For example:


Heading

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut pharetra sit amet aliquam id diam maecenas. Aliquam sem fringilla ut morbi tincidunt augue interdum velit euismod. Vitae et leo duis ut. Pharetra massa massa ultricies mi quis hendrerit dolor. Tincidunt vitae semper quis lectus nulla at volutpat. Sit amet facilisis magna etiam tempor orci eu lobortis. Aliquam etiam erat velit scelerisque in dictum non consectetur a. Accumsan in nisl nisi scelerisque eu ultrices vitae auctor eu. Tristique risus nec feugiat in fermentum posuere urna nec tincidunt. Nisl nunc mi ipsum faucibus vitae.

Et netus et malesuada fames ac turpis egestas integer eget. Tortor pretium viverra suspendisse potenti nullam ac tortor. Blandit cursus risus at ultrices mi. Faucibus interdum posuere lorem ipsum dolor sit amet consectetur. Fermentum leo vel orci porta non pulvinar neque laoreet. Netus et malesuada fames ac turpis. Eu lobortis elementum nibh tellus molestie nunc. Sit amet purus gravida quis blandit turpis cursus. Dignissim convallis aenean et tortor at. Nisl condimentum id venenatis a. Commodo odio aenean sed adipiscing diam donec adipiscing tristique. Consectetur lorem donec massa sapien faucibus et molestie ac feugiat. Purus faucibus ornare suspendisse sed nisi. Neque volutpat ac tincidunt vitae semper quis lectus nulla. Volutpat blandit aliquam etiam erat velit scelerisque. Tellus elementum sagittis vitae et leo duis ut diam quam. Urna neque viverra justo nec ultrices dui sapien eget. Nullam non nisi est sit.

@filiptronicek
Copy link
Contributor

I dig it. Looks awesome! @nthnchu

@stale
Copy link

stale bot commented Dec 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue is marked as stale. label Dec 6, 2020
@stale stale bot closed this as completed Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Issues, fixes related to design or alignments. stale Issue is marked as stale.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants