Choose which Github Dark Theme

[2br-2b]

Since there's already 5 PRs about this (one of which is mine), there should probably be an issue for this.

Which dark mode theme should be added?

Our current options:

#691 by @ErickSimoes

#758 by @issy

#811 by @microhod

#823 by @hd4y2t

#843 by @2br-2b

Related to issues #25, #79, #689, and many others

[ErickSimoes]

Can I vote for mine?

[ErickSimoes]

If I can't vote for mine, I choose #758 by @issy

[hd4y2t]

it's so hard

[2br-2b]

When making my dark theme, I did my best to mirror the colors from a pinned repo from the Github profile screen. I'd post a screenshot, but my screenshot tool is changing the colors in the screenshot for some reason.

[microhod]

If I can't vote for mine, I choose #758 by @issy

Yeah I agree, if I ignore my preference for my own, I'd vote #758 (although I'd prefer if it was modified slightly so that all the shades of blue match).

In general I feel like the colours 'pop' better in the ones that include the blue.

[alik604]

if my vote matters:
id say #758 by @issy. maybe with the offwhite text more white/bright

[2br-2b]

Hi @alik604 ! Of course every opinion matters!

It seems quite clear that #758 is the most popular choice.

@microhod , could you post an example of what you're talking about so that we can compare it with the current version?

Also, could someone who has a working screenshot tool post a picture of #758 in a home screen? That way, we can see what the final result looks like.

[Karthik-Nayak98]

I would choose #758 by @issy. Because it looks much bright than others.

[2br-2b]

Keep in mind that not everyone uses dark mode. The chosen theme should look good in dark mode and light mode.

[issy]

Here is a picture of my theme in action. First pic is in light mode


You can check this out yourself on my profile :)

[Karthik-Nayak98]

If there is border then we can differentiate between the colors of the card and background.

[issy]

If there is border then we can differentiate between the colors of the card and background.

They are the same colour, there is no border

[2br-2b]

If there are no objections, I think it's okay to merge #758 and close the other 4 PRs @anuraghazra

[ErickSimoes]

I agree 👍

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[2br-2b]

Any updates on this?

[anuraghazra]

Choosing #758 because of it's good contrast and visibility compared to others.

[anuraghazra]

Closed via #758