Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out highway=proposed and other non-roads? #20

Open
RicoElectrico opened this issue Jan 26, 2020 · 4 comments
Open

Filter out highway=proposed and other non-roads? #20

RicoElectrico opened this issue Jan 26, 2020 · 4 comments

Comments

@RicoElectrico
Copy link

RicoElectrico commented Jan 26, 2020

Hi, I found your visualization very addictive. I shared it on FB and someone noticed it also includes roads that don't exist (yet) - highway=proposed.

I think the best solution would be to explicitly filter for known highway types meant for cars. Like:
way[highway~"^(((motorway|trunk|primary|secondary|tertiary)(_link)?)|unclassified|residential|living_street|service|track)$"]
Debuggex diagram here

That would also filter out bus stops mapped as areas (some people map them like that) - ways with highway=bus_stop area=yes.

@anvaka
Copy link
Owner

anvaka commented Jan 28, 2020

Hi Rico, I like this a lot. It gives smaller responses, and it seems faster. I'm updating the cache now, and will migrate to this once cache is done.

@anvaka
Copy link
Owner

anvaka commented Jan 29, 2020

Here is a visual difference. On the left you see Seattle with proposed regex. On the right is original drawing (without highway filters). Which one do you like better?

image

@RicoElectrico
Copy link
Author

I think the left looks more clean, in line with the minimalist style. For many cities, there'd be less spots from partially mapped sidewalks as well.
I forgot about highway=pedestrian, which is as wide as a normal street and can be sometimes used by cars. You may also want to filter out area=yes (I'm unsure about performance impact of it).

way[highway~"^(((motorway|trunk|primary|secondary|tertiary)(_link)?)|unclassified|residential|living_street|pedestrian|service|track)$"][area!=yes]

@patzi
Copy link

patzi commented Jan 31, 2020

But if you filter out footways or cycleways it could mean to loose a lot of ways inside a city. Think of huge parks or the bicycle roads that are built in more and more cities. I think this could lead to a lot empty spots in some cities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants