WIP: add options for more custom queries #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm generally not good at FE stuff, so it is not a super design (if I need to do sth I usually just grab bootstrap or vuetify), but it works, and adds the options for the four premade query.
I think it would worth to add a free-text version, and some hints to the premade options. Probably it would worth to rename the
qparam toclike city oraas area, and move the query toq.Any idea? Improvement options?
Probably would fix: #3 #20 #31
Could be move this further to solve: #13 (for this probably we should write a query builder)
EDIT:
I forgot at first, but the pre-generated proto database should be either pre/postfixed and get new fields, or that will be kinda useless if more options are easily reachable for everybody.