Skip to content
This repository has been archived by the owner on Feb 25, 2019. It is now read-only.

Improve coveralls in travis build #293

Merged

Conversation

henrjk
Copy link
Contributor

@henrjk henrjk commented Oct 30, 2015

Add coveralls badge and improve build script.

Update original comment!

The introduction of the coveralls build somewhat unintentionally
had all tests running at once. This used to fail which was the reason
that the coverage.sh script was introduced so that the coverage would
run separately for unit and integration tests and the results were combined.

However it should really be possible to run all tests at once, so that
it makes sense to do so in the build. This should allow to see regressions
in this respect.

The coverage script itself is kept as it can still be useful during
development if only to see how one can run the commands in a shell without
installing istanbul or mocha globally.

Finally the travis script now sends coverage data in a second step to
coveralls with the intent to easier distinguish cases where the tests fail and
where coveralls fails.

The introduction of the coveralls build somewhat unintentionally
had all tests running at once. This used to fail which was the reason
that the coverage.sh script was introduced so that the coverage would
run separately for unit and integration tests and the results were combined.

However it should really be possible to run all tests at once, so that
it makes sense to do so in the build. This should allow to see regressions
in this respect.

The coverage script itself is kept as it can still be useful during
development if only to see how one can run the commands in a shell without
installing istanbul or mocha globally.

Finally the travis script now sends coverage data in a second step to
coveralls with the intent to easier distinguish cases where the tests fail and
where coveralls fails.
@henrjk henrjk force-pushed the coveralls-build-improvements branch from fbae53c to 561557a Compare October 30, 2015 09:35
@henrjk
Copy link
Contributor Author

henrjk commented Oct 30, 2015

The build bage an only be seen in master.

This should be good to be pulled now.

@christiansmith
Copy link
Member

Thanks!

christiansmith added a commit that referenced this pull request Nov 9, 2015
@christiansmith christiansmith merged commit f2cde54 into anvilresearch:master Nov 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants