Executable seemingly a no-op since version 0.9.2

[jugglinmike]

Hello! Starting with version 0.9.2, this project's executable stopped responding to command-line arguments and standard input, simply returning with a 0 exit status in all conditions:

$ file ~/.cargo/bin/cddl
/home/vagrant/.cargo/bin/cddl: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=2cb5ffebd6a34fa4efbb556be82d9761efa49aa5, for GNU/Linux 3.2.0, with debug_info, not stripped
$ ~/.cargo/bin/cddl; echo $?
0
$ ~/.cargo/bin/cddl help; echo $?
0
$ echo hello? | ~/.cargo/bin/cddl; echo $?
0

I have observed this behavior after installing the binary using cargo on a Debian VM (via libvert) and on a macOS system. I can also reproduce it using the binaries hosted by GitHub.com on either of those systems:

$ wget --quiet -O - https://github.com/anweiss/cddl/releases/download/0.9.0/cddl-linux-amd64.tar.gz | tar xz; file cddl-linux-amd64; ./cddl-linux-amd64 --version && echo $?
cddl-linux-amd64: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=9352366f2ab3047ea0cf56667d45174fd5107515, for GNU/Linux 3.2.0, with debug_info, not stripped
cddl 0.9.0
0
$ wget --quiet -O - https://github.com/anweiss/cddl/releases/download/0.9.1/cddl-linux-amd64.tar.gz | tar xz; file cddl-linux-amd64; ./cddl-linux-amd64 --version && echo $?
cddl-linux-amd64: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=2ebb4d77f7f5f8797f19059c2fee04035014a4fe, for GNU/Linux 3.2.0, with debug_info, not stripped
cddl 0.9.1
0
$ wget --quiet -O - https://github.com/anweiss/cddl/releases/download/0.9.2/cddl-linux-amd64.tar.gz | tar xz; file cddl-linux-amd64; ./cddl-linux-amd64 --version && echo $?
cddl-linux-amd64: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=f8ada268cdd2dc4fc351b66be9123e2f6e5b0704, for GNU/Linux 3.2.0, with debug_info, not stripped
0
$ wget --quiet -O - https://github.com/anweiss/cddl/releases/download/0.9.3/cddl-linux-amd64.tar.gz | tar xz; file cddl-linux-amd64; ./cddl-linux-amd64 --version && echo $?
cddl-linux-amd64: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=8b88c5f72205907bd30d34e1d2752526de80e81b, for GNU/Linux 3.2.0, with debug_info, not stripped
0

[whimboo]

I've the exact same problem on my MacBook Pro. I checked with bisect which commit is the cause of this change in behavior and found 007dabb (#206).

Since this change cli.rs is basically a no-op because everything has been commented out. I assume this was a change for debugging some code and was forgotten to revert?

@anweiss can you please have a look? It would be great to havea a working cddl binary again with all the recent additions. Thanks!

[anweiss]

Thanks for reporting!! Sorry about this. Indeed was an oversight on my part. Just released 0.9.4 and yanked 0.9.3. Let me know if this resolves the issue.

[whimboo]

Yes, it works all fine now in 0.9.4. Thanks for immediately releasing the new version!

[whimboo]

@anweiss please note that 0.9.2 is busted as well and maybe should also be yanked?

[anweiss]

Yep, both 0.9.2 and 0.9.3 have been yanked.

[whimboo]

Perfect. :) So I assume we can close this issue as well given that everything has been addressed.

[anweiss]

You bet! Re-open if need be.