External listener fd #310
External listener fd #310
Conversation
|
Looks like the sr.ht CI is being activated on GitHub PRs somehow but I don't see any indication of it checking out to my commit object. If it needs to be on PRs the linker should be failing on mine. |
layercak3
force-pushed
the
external-listener-fd
branch
2 times, most recently
from
96da611
to
daec8dc
Compare
|
Force-pushed new commits with review addressed. |
|
For some reason, the integration test is segfaulting on the github CI, but not srht. |
|
I deployed this on my server and external listener fd works, but it seems that I broke normal address listening after the review (I think I remember it working while working on the patch initially), maybe due to the atoi/option parser retval after removing the boolean. I'll have to fix that. edit: clearly I used the wrong executable to test normal address listening as I forgot to set the default value in the option parser with the option unset, sorry about that |
|
I checked on another user's PR and it was doing git checkout (https://builds.sr.ht/~andri/job/1227912), so I was wrong about that, it's only happening to my PRs, probably cause I named the repo "wayvnc-ghfork", maybe a bug in hottub-bridge :) |
layercak3
force-pushed
the
external-listener-fd
branch
from
daec8dc
to
e84bc31
Compare
|
LGTM. There are conflicts. Can you resolve them? |
layercak3
force-pushed
the
external-listener-fd
branch
from
e84bc31
to
f9e86cc
Compare
|
Rebased |
layercak3
force-pushed
the
external-listener-fd
branch
from
f9e86cc
to
7459e44
Compare
Instead of having wayvnc/neatvnc create a socket and listen() on it, allow listening on an already bound socket file descriptor with the --external-listener-fd=FD option. This may be used to support any kind of connection-based socket that isn't explicitly supported by wayvnc in an option, such as ones using the AF_VSOCK address family, or support cases where wayvnc is being activated by systemd (via a .socket unit) or a super-server like inetd.
layercak3
force-pushed
the
external-listener-fd
branch
from
7459e44
to
25cb597
Compare
|
Thanks! |
Tested with a systemd .socket unit.
Closes: #227
Requires: any1/neatvnc#111
I have read and understood CONTRIBUTING.md.