Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boilerplate > Table page layout > Create a reusable component for pages with one table #33

Merged
merged 6 commits into from
Apr 21, 2021

Conversation

dvikas
Copy link
Contributor

@dvikas dvikas commented Apr 11, 2021

Ticket references

Summary of changes

Added switching between Dark and Light theme
image

Slots Available

  • header-left
  • header-right
  • control-left
  • control-right
  • content
  • paginate

Checklist

  • bugfix
  • new feature
  • breaking change
  • added unit tests
  • changes introduced has been discussed and approved
  • requires manual testing
  • documentation has been updated

Testing

We need manual testing.

…t done. Used utils.js and FPaginate.vue of other projects. Table contain mock of Server side pagination.
src/i18n/en/index.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@pandafox pandafox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sample tables and data should prob be moved to a sample folder, otherwise we'd need to spend considerable amount cleaning up?

…in name only (sortable and align are optional). Translation file follows snake_case. Updated FPaginate component as per table pagination attributes of Quasar. Moved Page per Options to config.

dev-3914
src/App.vue Outdated Show resolved Hide resolved
src/components/partials/tables/FTable.vue Outdated Show resolved Hide resolved
src/components/partials/tables/FTable.vue Outdated Show resolved Hide resolved
src/components/partials/tables/FTable.vue Outdated Show resolved Hide resolved
src/components/partials/tables/FTable.vue Outdated Show resolved Hide resolved
src/components/partials/tables/FTable.vue Show resolved Hide resolved
src/components/partials/tables/FTable.vue Outdated Show resolved Hide resolved
src/components/partials/tables/FTable.vue Outdated Show resolved Hide resolved
src/components/partials/tables/FTable.vue Outdated Show resolved Hide resolved
src/components/partials/tables/FTable.vue Outdated Show resolved Hide resolved
src/components/partials/tables/FTable.vue Outdated Show resolved Hide resolved
@dvikas
Copy link
Contributor Author

dvikas commented Apr 14, 2021

Hi @axlepascual, @pandafox <slot> is already there as control-left, so we can use a text, a searchbar in some cases, dropdown buttons, etc. But to make it simpler for tabs I provided a way to pass tabs Data as props

        <f-table
            :tabs-data="headerTabs"
            :selected-tab="selectedTab"
            :page-header="false"
            tab-indicator-color="transparent"
        >

So it will help to not write code of tabs repeatedly.
#33 (comment)

@dvikas dvikas changed the title Boilerplate > Table page layout > Create a reusable component for pages with one table [WIP]Boilerplate > Table page layout > Create a reusable component for pages with one table Apr 19, 2021
…ble component removed breadcrumbs, Tabs and other components.

dev-3914
pandafox
pandafox previously approved these changes Apr 19, 2021
@dvikas dvikas changed the title [WIP]Boilerplate > Table page layout > Create a reusable component for pages with one table Boilerplate > Table page layout > Create a reusable component for pages with one table Apr 19, 2021
@wilbertverayin
Copy link
Contributor

image

@jonelrempis
Copy link
Contributor

jonelrempis commented Apr 20, 2021

  • image

@kiko-f
Copy link

kiko-f commented Apr 21, 2021

@jonelrempis jonelrempis merged commit 8936126 into master Apr 21, 2021
@jonelrempis jonelrempis deleted the feature/dev-3914-reusable-table-page-layout branch April 21, 2021 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants