Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In freeze, Git tag gets replaced with potentially unusable SHA #33

Open
gracinet opened this issue Jan 20, 2015 · 3 comments
Open

In freeze, Git tag gets replaced with potentially unusable SHA #33

gracinet opened this issue Jan 20, 2015 · 3 comments
Labels

Comments

@gracinet
Copy link
Contributor

This is a special case of issue #2 which qualifies as a bug (infrequent)

Actually, even tags used in the buildout to freeze get replaced by their SHA (which at least cannot be garbage collected).

Now, SHAs can be fetched only if they are reachable from the HEAD of remote repo (typically master), which means that currently tags on feature branches cannot be used at all in the freeze/extract part of the process. This is not a projection, it just happened on a real project at Anybox.

@gracinet gracinet added the bug label Jan 20, 2015
@foutoucour
Copy link

We are facing the same issues at Savoir-faire Linux.
We had to make a wrapper to run a bit of code before to run the freeze command.

The bit of code looks like:

git clean -xfd
git reset --hard origin/8.0

Hope it helps

@gracinet
Copy link
Contributor Author

@foutoucour thanks for feedback, but I think it's unrelated.

Indeed the commands you're showing actually circumvent the refusal to freeze if local modifications of any kind are found, which is a feature deliberately introduced from the ground up: it protects the user against releasing something that may behave differently than the local copy (a local modification actually leading to a significative behaviour difference is uncommon, but each occurrence has a high cost in terms of debugging time).
So in short, I don't recommend what you're doing, unless one is sure in the given context that any local modifications are superficial. And even in that case, I'd try to circumvent with .gitgnore first.

In the past, it has happened that local modifications could have been introduced by the recipe itself (setup.py) in which case of course nothing becomes releasable, in particular not on bots, and that's been treated as a bug in itself.

Regards,

gracinet pushed a commit that referenced this issue Jan 26, 2015
The new is_local_fixed_revision() will be used by freeze-to() to decide
whether a revision specification must be replaced by a frozen one or not.
@gracinet
Copy link
Contributor Author

@sandreanybox would you please be so kind to try the current a.r.openerp-1.9 branch, namely the [8ae5bb6] I just pushed. They should work better for you.
cc @jssuzanne, since we talked about it earlier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants