Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable debug log by default #6

Closed
missedone opened this issue Jun 9, 2017 · 6 comments
Closed

disable debug log by default #6

missedone opened this issue Jun 9, 2017 · 6 comments

Comments

@missedone
Copy link

hi,
I ran buttervolume from the pre-baked docker image:

root@ca4c855d6f0d:/# buttervolume snapshots
DEBUG:requests.packages.urllib3.connectionpool:http://localhost:None "POST /VolumeDriver.Snapshot.List HTTP/1.1" 200 28
  1. http://localhost:None, the port "None" looks confusing, though the result is good
  2. can we disable the DEBUG log by default?
    thx
@petrus-v
Copy link

petrus-v commented Jun 9, 2017

Hi,

Thanks for report, yes good Idea, do you mind to do the PR for that?

regards

@missedone
Copy link
Author

sorry, i'm not quite family with the buttervolume code structure, i tried add line logging.getLogger('requests.packages.urllib3.connectionpool').setLevel(logging.INFO) to cli.py, but looks like it does not work.

@petrus-v
Copy link

Oops, reading the code, it's looks like level info is an hard coded value on each files:

We have to change that behavior and be able to set logging config from parameters.

@marcelo-ochoa
Copy link

I changed LogLevel to ERROR in both files. See code at #11 #9

@petrus-v
Copy link

@marcelo-ochoa,

Yes I've seen that, I think at the time this issue was created it was ``DEBUG```level but anyway this should be settable somehow!

@ccomb
Copy link
Member

ccomb commented Mar 24, 2018

In buttervolume 2.0 the log level is configurable through an environment variable or an /etc/buttervolume/config.ini file.

@ccomb ccomb closed this as completed Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants