[Enhancement] Multiple snapshots as new mounts (clone volume) #9

[marcelo-ochoa]

Here propesed patch as discussed in Issue #9

[petrus-v]

Hi,

Thanks for this PR, code looks good to me, can you add a unit test like test_restore about this new functionality and I will be happy to merge it!

[marcelo-ochoa]

Sure, I'll try to do it, remember I am not a phyton developer ;)
Marcelo.

[petrus-v]

@marcelo-ochoa,

Yes I remember... but, but with this PR you are proving that now you are a python developer! ;-p

Thanks for that works and take time to invest on it!

[marcelo-ochoa]

Done test_clone.

[petrus-v]

Before updating the file in the freshly cloned volume could you make sure it contains foobar to make sure we clone properly create a snapshot?
by adding following snippet before this part:

+        # check the cloned volume has a copy of the original content
+        with open(join(path2, 'foobar')) as f:
+            self.assertEqual(f.read(), 'foobar')

I don't remember if we snapshot twice in an existing volume, but this is an other story related to the snapshot method don't worry about it here!

[petrus-v]

LGTM.

Thanks!