Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #121 #122

Merged
merged 1 commit into from
May 31, 2019
Merged

Fix #121 #122

merged 1 commit into from
May 31, 2019

Conversation

anykeyh
Copy link
Owner

@anykeyh anykeyh commented May 31, 2019

Allow column_name option to be used to select a different name for mapping between model's variable and table's column.

Motivation and Context

The option was here already long time ago but never been tested. The option regressed until someone noticed it (#121)

How Has This Been Tested?

A small test has been written to ensure than fundamentals are working. Since I need to rework the test sets, a bigger test set should be done later.

Types of changes

Should not break anything, but change a lot the macros so who knows...

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. bin/ameba ran without alert.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@anykeyh anykeyh merged commit ec2714b into master May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant