Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom converter spec detailed as example in the manual #199

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dukeraphaelng
Copy link
Contributor

Description

  • Add spec demonstrating working custom converter detailed in the manual

Motivation and Context

  • To clarify custom converter working in action

How Has This Been Tested?

  • Spec added in spec/model/converters/custom_converter_spec
  • All specs passed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Manual of usage of the new feature.

Checklist:

  • My code follows the code style of this project. bin/ameba ran without alert.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@dukeraphaelng dukeraphaelng changed the title Add custom converter spec for manual example Add custom converter spec detailed as example in the manual Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant