Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON::Deserialize not working with column_name field #203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dukeraphaelng
Copy link
Contributor

Description

db_column_name = column_name == nil ? name.var : column_name.id

The key is assigned to the method name, name.var by default but will be re-assigned to column_name.id if declared, which is the name of the column in the database, not the name of the method.

We need to use the method name and not the column_name, hence the change from {{name.id}} to {{settings["crystal_variable_name"]}}

Motivation and Context

How Has This Been Tested?

  • All specs passed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Manual of usage of the new feature.

Checklist:

  • My code follows the code style of this project. bin/ameba ran without alert.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: JSONDeserialize module not handling
1 participant