Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reproducible typescript output (#1159) #1179

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

rnm-sxm
Copy link
Contributor

@rnm-sxm rnm-sxm commented Jan 24, 2024

Status

READY

Description

Sort schemas after reading input files and before generating output.

Related PRs

Fixes #1159

Todos

  • Tests
  • Documentation (N/A)
  • Changelog Entry (unreleased)

Steps to Test or Reproduce

Extract the workspace from reproduce.tar.gz

# generate the OpenApi schema
> python3 gen.py

# generate Typescript using orval
> npx orval

# Make a copy of the output
> cp gen/reproduce.ts gen/reproduce-one.ts

# Rerun the generator
> npx orval

# diff the two outputs
> diff gen/reproduce-one.ts gen/reproduce.ts

The two output files should be identical.

@melloware melloware added the enhancement New feature or request label Jan 24, 2024
@melloware melloware added this to the 6.24.0 milestone Jan 24, 2024
@melloware
Copy link
Collaborator

Running the tests now

@melloware melloware merged commit a11e821 into anymaniax:master Jan 24, 2024
2 checks passed
@rnm-sxm rnm-sxm deleted the fix_1159_reproducible_output branch January 24, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reproducable TypeScript output
2 participants