Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: overridden non-GET queries not generating hooks #1251

Merged
merged 2 commits into from
Mar 5, 2024
Merged

fix: overridden non-GET queries not generating hooks #1251

merged 2 commits into from
Mar 5, 2024

Conversation

ponbac
Copy link
Contributor

@ponbac ponbac commented Mar 5, 2024 •
edited by melloware

Status

READY

Fix #1247

Description

As described in #1247 hooks for queries with a verb other than GET did not get generated even though an operation override was present.

Seems like the isQuery variable was changed in #1212 but the queries list containing which queries to generate hooks for still used the old condition.

Todos

  • Tests
  • Documentation
  • Changelog Entry (unreleased)

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

> git pull --prune
> git checkout <branch>
> grunt jasmine
  1. Described in issue Regression when updating from 6.21 to 6.22.0 #1247

@melloware melloware added this to the 6.26.0 milestone Mar 5, 2024
@melloware melloware added the bug Something isn't working label Mar 5, 2024
@melloware melloware merged commit 05bb15b into anymaniax:master Mar 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melloware melloware melloware approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
6.26.0
Development

Successfully merging this pull request may close these issues.

Regression when updating from 6.21 to 6.22.0
2 participants
@ponbac @melloware