fix: take optional request body into account when creating form data

[AffeJonsson]

Status

READY

Description

Fixes #1392
This makes sure to check for undefined in case the request body is optional. This also contains changes to not cast to any when handling subtypes.

Before:

export const createPets = (
  pet?: Pet,
  version: number = 1,
  options?: AxiosRequestConfig,
): Promise<AxiosResponse<Pet>> => {
  const formData = new FormData();
  if ((pet as any).name !== undefined) {
    formData.append('name', (pet as any).name);
  }
  if ((pet as any).tag !== undefined) {
    formData.append('tag', (pet as any).tag);
  }

  if ((pet as any).id !== undefined) {
    formData.append('id', (pet as any).id.toString());
  }
  if ((pet as any).name !== undefined) {
    formData.append('name', (pet as any).name);
  }
  if ((pet as any).tag !== undefined) {
    formData.append('tag', (pet as any).tag);
  }
  if (pet['@id'] !== undefined) {
    formData.append('@id', pet['@id']);
  }
  if (pet.email !== undefined) {
    formData.append('email', pet.email);
  }
  if (pet.callingCode !== undefined) {
    formData.append('callingCode', pet.callingCode);
  }
  if (pet.country !== undefined) {
    formData.append('country', pet.country);
  }

  return axios.post(`/v${version}/pets`, formData, options);
};

After:

export const createPets = (
  pet?: Pet,
  version: number = 1,
  options?: AxiosRequestConfig,
): Promise<AxiosResponse<Pet>> => {
  const formData = new FormData();
  const petPetBase = pet as PetBase | undefined;
  if (petPetBase?.name !== undefined) {
    formData.append('name', petPetBase.name);
  }
  if (petPetBase?.tag !== undefined) {
    formData.append('tag', petPetBase.tag);
  }

  const petPetExtended = pet as PetExtended | undefined;
  if (petPetExtended?.id !== undefined) {
    formData.append('id', petPetExtended.id.toString());
  }
  if (petPetExtended?.name !== undefined) {
    formData.append('name', petPetExtended.name);
  }
  if (petPetExtended?.tag !== undefined) {
    formData.append('tag', petPetExtended.tag);
  }
  if (pet?.['@id'] !== undefined) {
    formData.append('@id', pet['@id']);
  }
  if (pet?.email !== undefined) {
    formData.append('email', pet.email);
  }
  if (pet?.callingCode !== undefined) {
    formData.append('callingCode', pet.callingCode);
  }
  if (pet?.country !== undefined) {
    formData.append('country', pet.country);
  }

  return axios.post(`/v${version}/pets`, formData, options);
};

Todos

• Tests
• Documentation
• Changelog Entry (unreleased)

Steps to Test or Reproduce

generate:react-query
generate:swr

[AffeJonsson]

Noticed the cast to subtype only worked if mocks were generated, I'll fix a commit where they are imported properly

[soartec-lab]

@AffeJonsson
I have consulted with you about how to extend the function, so please check it out.

[soartec-lab]

Thanks !