Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make a layers of abstractions for your hard code implementation of Databse/Multiplayer/Events! #7

Closed
studentutu opened this issue Dec 30, 2020 · 1 comment

Comments

@studentutu
Copy link

You are doing a monkey job.
To avoid it - please make a layer of abstraction for Multiplayer System.
Add EventBus messanger to avoid hard coded events/classes
Please do not use Resources as your primary source of assets! It will be a neightmare to debug stuff with them.

@michaelday008
Copy link
Collaborator

I just saw this comment now.

Abstraction will definitely be added for multiplayer in the future. I haven't done any work with Unity multiplayer before though so at this point I'm not sure what that abstraction should even look like.

You can see the SystemEventManager is now starting to use a non-hard-coded event system. More events will be migrated to this system over time.

Resources were used originally because there is nothing worse than getting a Unity package from the Asset store and being required to spend a bunch of time learning whatever DB system the author chose and setup a database server before even being able to play. DB support will be used eventually when network support is added, but the goal of this package is that it 'just works' out of the box.

This request isn't really actionable is it contains multiple items that would each need to be individually tracked. If you have a specific use case for these features, feel free to open individual requests for each of them and describe the use case in more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants