Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endpoint escapes #69

Merged
merged 2 commits into from Jun 23, 2020
Merged

Endpoint escapes #69

merged 2 commits into from Jun 23, 2020

Conversation

nofun97
Copy link
Member

@nofun97 nofun97 commented Jun 23, 2020

Endpoints are now not escaped in titles and hyperlinks in applications indexes work

cuminandpaprika
cuminandpaprika reviewed Jun 23, 2020
View reviewed changes
Copy link
Contributor

@cuminandpaprika cuminandpaprika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, the formatting of endpoint names works nicely, but the anchor links still seem to be broken

@cuminandpaprika cuminandpaprika self-requested a review June 23, 2020 07:15
cuminandpaprika
cuminandpaprika approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@cuminandpaprika cuminandpaprika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, my mistake all working now!

@nofun97 nofun97 merged commit 57274da into anz-bank:master Jun 23, 2020
@nofun97 nofun97 deleted the endpoint-esc branch June 23, 2020 07:42
ChloePlanet pushed a commit that referenced this pull request Oct 7, 2020
@cuminandpaprika
Fix error when dir doesn't exist (#69)
0b5f1d9 
Adds a missing MkdirAll which creates the folders in the path if they do not already exist
Adds error and nil checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuminandpaprika cuminandpaprika cuminandpaprika approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nofun97 @cuminandpaprika