Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes source file link generation issue #79

Merged
merged 4 commits into from Jun 26, 2020

Conversation

nofun97
Copy link
Member

@nofun97 nofun97 commented Jun 25, 2020

Before links to source files weren't generated correctly. It tries to link to a memory filesystem that doesn't have the source files. This PR is a quick fix, it will try to generate a link to a github repo instead.

Copy link
Contributor

@cuminandpaprika cuminandpaprika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few nitpicks and an overwritten README file.
Could you document the link feature in the Readme btw, just briefly describing what it does and the limitations?

README.md Outdated Show resolved Hide resolved
demo/html/FirstDivision/index.html Outdated Show resolved Hide resolved
pkg/catalog/generator.go Show resolved Hide resolved
pkg/catalog/generator.go Show resolved Hide resolved
Copy link
Contributor

@cuminandpaprika cuminandpaprika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nofun97 nofun97 merged commit 462aa87 into anz-bank:master Jun 26, 2020
@nofun97 nofun97 deleted the hyperlink-fix branch June 26, 2020 04:41
anzopensource pushed a commit that referenced this pull request Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants