Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make admin server RESTful only #79

Open
andrewemeryanz opened this issue Apr 23, 2020 · 0 comments
Open

Make admin server RESTful only #79

andrewemeryanz opened this issue Apr 23, 2020 · 0 comments
Labels
P0 Highest priority: important and urgent

Comments

@andrewemeryanz
Copy link
Contributor

sysl-go currently supports a RESTful admin server by way of the Manager interface:

type Manager interface {
	AdminServerConfig() *config.CommonHTTPServerConfig
}

The GrpcManager interface also defines a server configuration but it isn't supported:

type GrpcManager interface {
	GrpcAdminServerConfig() *config.CommonServerConfig
}

The admin server should be only made available as a RESTful service. To support this, the admin server configuration should be removed from Manager and GrpcManager interfaces in favour of a standalone configuration avenue.

@andrewemeryanz andrewemeryanz added the P0 Highest priority: important and urgent label Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Highest priority: important and urgent
Projects
None yet
Development

No branches or pull requests

2 participants