Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename identity to authority in bench-tps #30145

Closed
KirillLykov opened this issue Feb 6, 2023 · 1 comment · Fixed by anza-xyz/agave#1435
Closed

Rename identity to authority in bench-tps #30145

KirillLykov opened this issue Feb 6, 2023 · 1 comment · Fixed by anza-xyz/agave#1435
Assignees
@KirillLykov

Comments

@KirillLykov
Copy link
Contributor

KirillLykov commented Feb 6, 2023 •
edited

Problem

Rename identity cli argument to authority because this keypair is used to fund accounts participating in benchmarking

Proposed Solution

This argument might be used in different CI pipelines, so the proposed solution is

  1. Add a new parameter authority
  2. Mark identity to be deprecated
  3. Switch to new name in CI and remove identity
@KirillLykov KirillLykov self-assigned this Feb 6, 2023
@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Feb 7, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 14, 2024
@KirillLykov KirillLykov reopened this Feb 14, 2024
@github-actions github-actions bot removed the stale [bot only] Added to stale content; results in auto-close after a week. label Feb 15, 2024
@kubanemil kubanemil mentioned this issue May 20, 2024
Merged
@KirillLykov
Copy link
Contributor Author

anza-xyz#1435 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KirillLykov KirillLykov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renaming --identity to --authority in bench-tps kubanemil/solana
1 participant
@KirillLykov