Renaming --identity to --authority in bench-tps

[kubanemil]

Problem

The keypair in bench-tps is used to fund accounts in benchmarking, so it should be renamed to --authority

Summary of Changes

Deprecated use of --identity. Substituted argument to --authority in tests. Currently, both names are usable.

Fixes solana-labs#30145

[kubanemil]

@KirillLykov @CriesofCarrots requesting your reviews.

[CriesofCarrots]

In future, please don't tag random contributors asking for review

[CriesofCarrots]

Lgtm.
@KirillLykov , I'll let you confirm this satisfies what you wanted in your issue, and merge.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.7%. Comparing base (94af1aa) to head (46309b0).
Report is 9 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #1435    +/-   ##
========================================
  Coverage    82.7%    82.7%            
========================================
  Files         872      872            
  Lines      370361   370389    +28     
========================================
+ Hits       306478   306592   +114     
+ Misses      63883    63797    -86     

[KirillLykov]

Thanks for fixing this issue! Could you also add a small test to cli.rs checking that identity works?

Probably in the follow up PR, would be nice to rename identity into authority in the scripts that we use to run bench-tps.

[kubanemil]

is it okay if I add this to test identity:

let keypair = read_keypair_file(&keypair_file_name).unwrap();
let matches = build_args("1.0.0").get_matches_from(vec![
    "solana-bench-tps",
    "--identity",
    &keypair_file_name,
    "-u",
    "http://123.4.5.6:8899",
]);
let actual = parse_args(&matches).unwrap();
assert_eq!(
    actual,
    Config {
        json_rpc_url: "http://123.4.5.6:8899".to_string(),
        websocket_url: "ws://123.4.5.6:8900/".to_string(),
        id: keypair,
        ..Config::default()
    }
);

Also, can you say which scripts are used to run bench-tps?

[KirillLykov]

@kubanemil yes, something like that would fit.

Regarding where it is used: in multinode-demo and some other shell scripts. Checkout particular places with grep -nr "\-\-identity" --include "*.sh".

[kubanemil]

I have checked out each shell script that uses identity as a CLI argument, none of them uses it for solana-bench-tps, they are used mostly as $ validator --identity.

[KirillLykov]

I have checked out each shell script that uses identity as a CLI argument, none of them uses it for solana-bench-tps, they are used mostly as $ validator --identity.

You are right. In this case, less work. Please rebase with upstream and add the test if not already and I will approve and merge

[kubanemil]

done