Despite skip_preflight being true, preflight_commitment is nevertheless used
#479
Labels
Comments
steveluscher
added a commit
to solana-labs/solana-web3.js
that referenced
this issue
Apr 3, 2024
…eflight checks (#2415) # Summary There's a bug in the `sendTransaction` RPC method where, when bypassing preflight, we nevertheless materially use the value of `preflightCommitment` to determine how to behave when sending the transaction. If you supply _nothing_ – as you might think appropriate when _skipping_ preflight – then the default of `finalized` will be used. Far from irrelevant, such a value can actually affect the retry behaviour of the send-transaction-service (STS). Read anza-xyz/agave#483 for more detail. In this PR, we try to get ahead of anza-xyz/agave#483 by setting this value to `processed` in the client. Until the server PR is deployed widely, this should cover those who choose to upgrade Addresses anza-xyz/agave#479 # Test plan ``` pnpm turbo test:unit:node test:unit:browser ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
I think that people have an expectation that
skip_preflightmakes it so that the value ofpreflight_commitmentis not used. In fact it's used unconditionally to prepare the ‘preflight bank’:https://github.com/anza-xyz/agave/blob/master/rpc/src/rpc.rs#L3650-L3653
…from which we compute the
last_valid_block_height:https://github.com/anza-xyz/agave/blob/master/rpc/src/rpc.rs#L3658-L3660
…and the
address_loaderforsanitize_transaction:https://github.com/anza-xyz/agave/blob/master/rpc/src/rpc.rs#L3655
Is it possible that this could nevertheless materially change
send_transaction'sbehaviour? @t-nelson suggested:Proposed Solution
Only use the
preflight_commitmentwhenskip_preflightistrue.The text was updated successfully, but these errors were encountered: