-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.17: Parameterize max streams per ms (backport of #707) #1105
Conversation
Cherry-pick of f2aa4f0 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Make PPS a parameter instead of the hard coded (cherry picked from commit f2aa4f0) # Conflicts: # client/src/connection_cache.rs # core/src/tpu.rs # quic-client/tests/quic_client.rs # streamer/src/nonblocking/quic.rs # streamer/src/nonblocking/stream_throttle.rs
6423d54
to
08ecd4e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.17 #1105 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 806 806
Lines 219335 219345 +10
=========================================
- Hits 179108 179067 -41
- Misses 40227 40278 +51 |
this is doing far more than the title implies. when did we decide to backport ema? this is too much |
stream_throttle.rs is a merge issue -- this PR does not need it. Removed. |
eca41c7
to
c6119ce
Compare
woot! |
Problem
The upper layer like jato-relayer may want different PPS for tpu and tpu_forward than the default value. Our validator may use different values for tpu vs forward. This changes makes it possible.
Summary of Changes
Make it parameter instead of the hard coded
Fixes #
This is an automatic backport of pull request #707 done by [Mergify](https://mergify.com).