Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of get_account_meta #1620

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

jeffwashington
Copy link

Problem

Moving to optional file i/o based storages instead of mmap.

Summary of Changes

Get rid of get_account_meta so that implementation of file i/o based storage is easier.

Fixes #

Copy link

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link

@alessandrod alessandrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. account_matches_owners was the only caller and must go too

@jeffwashington jeffwashington merged commit c038908 into anza-xyz:master Jun 6, 2024
42 checks passed
@HaoranYi
Copy link

HaoranYi commented Jun 6, 2024

lgtm. account_matches_owners was the only caller and must go too

yeah. account_matches_owners can be removed once the following to PRs are merged.
#1408 #1157

Copy link

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants