-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull sanitize crate out of solana-program #1707
Conversation
66570e1
to
44c2408
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, just to summarize, we're introducing a leaf-node crate for solana-santize
.
The monorepo packages which need the Sanitize
trait are:
bloom
core
gossip
version
The Sanitize
trait itself is designed for sanitizing over-the-wire message payloads, and >90% of downstream user cases of SDK and program SDK, will never need sanitize()
.
Regardless, here they are listed for posterity:
blake3
hashinghash
(sha2) hashingkeccak
hashingCompiledInstruction
Pubkey
Signature
- Almost all transaction message types
- Almost all transaction types
I'm in favor of this change. I think it makes sense for networking-related libraries to import solana-sanitize
if they need to rely on sanitized messages, and not to impose this requirement on other users of SDK types.
f9c3da9
to
4811bf6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm @kevinheavey, thanks for the continued crusade on dependencies!
On crates.io, add anza-team
and pull yourself as owner, and then retry the CI job.
Added, will remove myself as owner once anza-team accepts the ownership invite https://crates.io/crates/solana-sanitize/ |
4811bf6
to
cb39cd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just change the deprecated "since" version.
fab6098
to
32ea353
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks!
automerge label removed due to a CI failure |
Co-authored-by: Joe C <joecaulfield29@yahoo.com>
Co-authored-by: Joe C <joecaulfield29@yahoo.com>
This reverts commit fab6098.
32ea353
to
a73b32b
Compare
Problem
The Sanitize trait is a de facto internal trait that doesn't belong in solana-program, and it makes it harder to move a bunch of other things out of solana-program
Summary of Changes
Move sanitize.rs into a new solana-sanitize crate.