package-metadata: Add macro to define program id from Cargo.toml #1806
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is a remake of #1483 but using a new crate instead of adding to
solana_program
.We've added in the preliminary scaffolding in #1464 and #1465, but we still don't have the last bit to declare the program id in Cargo.toml.
Summary of Changes
Add the macro. As part of this, we have a few additions:
Pubkey::from_str_const
As noted in
Pubkey::from_str_const
, it's currently impossible to do a length check, which isn't great. We'll see if the upstream PR get accepted. I can keep this in draft until that goes through. I can also move that to a separate PR.cc @lorisleiva