Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract atomic-u64 crate #1824

Merged
merged 5 commits into from
Jul 3, 2024
Merged

Conversation

kevinheavey
Copy link

Problem

solana_program::atomic_u64 blocks moving a bunch of modules out of solana-program

Summary of Changes

Move atomic_u64 to its own crate and put "For internal use only" in the description since it was not a public module

@kevinheavey kevinheavey force-pushed the extract-atomic-u64 branch 3 times, most recently from 6c33751 to 8a75a77 Compare June 28, 2024 06:09
@kevinheavey kevinheavey force-pushed the extract-atomic-u64 branch 2 times, most recently from add3870 to ed0fd54 Compare July 1, 2024 08:54
Copy link

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me, and we don't even have to worry about deprecation, since it was all pub(crate).

Is there any reason why we may introduce other atomic integer values? Should we not shackle ourselves here and maybe call this solana-atomic-integer? What do you think?

@kevinheavey
Copy link
Author

Meh, crates are free and the only constraint this imposes is that someone who wants to do something different in the future will have to make a new crate instead of bloating this one

@kevinheavey kevinheavey force-pushed the extract-atomic-u64 branch 2 times, most recently from eedb6b2 to 591f576 Compare July 2, 2024 14:02
@buffalojoec
Copy link

buffalojoec commented Jul 3, 2024

Meh, crates are free and the only constraint this imposes is that someone who wants to do something different in the future will have to make a new crate instead of bloating this one

Fair enough, but the word "bloating" is a stretch for a crate that's 38 lines long.

Just give this a quick rebase and I'll stamp it. Thanks!

@kevinheavey kevinheavey added the automerge automerge Merge this Pull Request automatically once CI passes label Jul 3, 2024
@mergify mergify bot merged commit a37bc49 into anza-xyz:master Jul 3, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes need:merge-assist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants