-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract atomic-u64 crate #1824
Extract atomic-u64 crate #1824
Conversation
6c33751
to
8a75a77
Compare
add3870
to
ed0fd54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks good to me, and we don't even have to worry about deprecation, since it was all pub(crate)
.
Is there any reason why we may introduce other atomic integer values? Should we not shackle ourselves here and maybe call this solana-atomic-integer
? What do you think?
Meh, crates are free and the only constraint this imposes is that someone who wants to do something different in the future will have to make a new crate instead of bloating this one |
eedb6b2
to
591f576
Compare
Fair enough, but the word "bloating" is a stretch for a crate that's 38 lines long. Just give this a quick rebase and I'll stamp it. Thanks! |
591f576
to
221e110
Compare
221e110
to
00ce2bb
Compare
Problem
solana_program::atomic_u64
blocks moving a bunch of modules out of solana-programSummary of Changes
Move atomic_u64 to its own crate and put "For internal use only" in the description since it was not a public module