v1.18: BankingStage Forwarding Filter (backport of #685)

[mergify]

Problem

• Forwarding all packets, when many will ultimately be duplicates

Summary of Changes

• Only forward packets that were from staked connections (swqos)

Fixes #

---

This is an automatic backport of pull request #685 done by [Mergify](https://mergify.com).

[mergify]

Cherry-pick of 1744e9e has failed:

On branch mergify/bp/v1.18/pr-685
Your branch is up to date with 'origin/v1.18'.

You are currently cherry-picking commit 1744e9efd7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   bench-streamer/src/main.rs
	modified:   core/src/banking_stage/forwarder.rs
	modified:   core/src/fetch_stage.rs
	modified:   core/src/repair/ancestor_hashes_service.rs
	modified:   core/src/repair/serve_repair_service.rs
	modified:   core/src/shred_fetch_stage.rs
	modified:   gossip/src/gossip_service.rs
	modified:   local-cluster/tests/local_cluster.rs
	modified:   streamer/src/nonblocking/quic.rs
	modified:   streamer/src/streamer.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   sdk/src/packet.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.6%. Comparing base (cf5e8d3) to head (91bbcbb).

Additional details and impacted files

@@           Coverage Diff           @@
##            v1.18     #697   +/-   ##
=======================================
  Coverage    81.5%    81.6%           
=======================================
  Files         827      827           
  Lines      224833   224844   +11     
=======================================
+ Hits       183440   183491   +51     
+ Misses      41393    41353   -40     

[tao-stones]

lgtm

[t-nelson]

r+ ci. only difference from previous approvals is removing test hacks in favor of a more appropriate fix in #724

[tao-stones]

lgtm

[steviez]

LGTM

[behzadnouri]

The convention is that the trailing comment should be the argument name; is_staked_service here.
This is kind of "double negative" and confusing. Does "false unstaked" mean "staked"?

[apfitzge]

there's already instances of both "explanation" style comments on bool arguments, as well as "name" style comments.

This is a backport, keep it the same as the original. If we feel strongly enough about the style we should be making modifications to master, not in a backport PR.

[behzadnouri]

Please follow the code style.

The comments makes the life of someone reading this code a lot easier and also makes bugs/mistakes less likely.

[apfitzge]

see above.

[behzadnouri]

https://rust-lang.github.io/rust-clippy/master/index.html#/needless_for_each

[apfitzge]

clippy didn't flag it, see above comment about style.