Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVM: move bpf-loader-program to dev-dependencies #711

Merged

Conversation

kevinheavey
Copy link

@kevinheavey kevinheavey commented Apr 10, 2024

Problem

solana-bpf-loader-program is only needed as a dev dependency

Summary of Changes

Move it to dev-dependencies

@mergify mergify bot requested a review from a team April 10, 2024 13:38
@buffalojoec buffalojoec added CI Pull Request is ready to enter CI automerge automerge Merge this Pull Request automatically once CI passes labels Apr 10, 2024
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Apr 10, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.9%. Comparing base (72ee270) to head (991fd62).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #711   +/-   ##
=======================================
  Coverage    81.9%    81.9%           
=======================================
  Files         851      851           
  Lines      230726   230726           
=======================================
+ Hits       189009   189025   +16     
+ Misses      41717    41701   -16     

@buffalojoec buffalojoec merged commit ff8a25b into anza-xyz:master Apr 10, 2024
41 checks passed
@dmakarov
Copy link

dmakarov commented Apr 10, 2024

I would prefer that in the future if we use the PR description prefix, we stick with consistent spelling in upper case letters SVM: not svm:

@kevinheavey kevinheavey changed the title svm: move bpf-loader-program to dev-dependencies SVM: move bpf-loader-program to dev-dependencies Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes community need:merge-assist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants