Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes required for Solang #10

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Fixes required for Solang #10

merged 2 commits into from
Apr 13, 2021

Conversation

seanyoung
Copy link

No description provided.

@dmakarov
Copy link
Collaborator

I add the prefix [SOL][BPF] to every commit message, to distinguish visually the commits that are Solana specific, so I don't miss them when I update the source tree to a new snapshot of llvm-project. It would be nice if your commit message had this prefix too ([BPF] may be not applicable to clang or lld changes, but I would appreciate having the [SOL] prefix).

@seanyoung
[SOL] Make lld thread-safe with llvm when used in-process
a9186e5 
Every time Solang tries to link a web-assembly file in-process, the linker
re-inits llvm which is not thread-safe with the rest of solang.

Signed-off-by: Sean Young <sean@mess.org>
@seanyoung
Copy link
Author

I've updated the commit messages.

@dmakarov
Copy link
Collaborator

LGTM. Let's wait for the CI checks to finish (it'll take some time), and then this can be merged. Thank you.

@seanyoung seanyoung changed the title llvm fixes required for Solang Fixes required for Solang Apr 13, 2021
@seanyoung
Copy link
Author

seanyoung commented Apr 13, 2021 •
edited
Loading

Looks like all CI checks have passed

@dmakarov dmakarov merged this pull request into anza-xyz:solana-rustc/11.0-2021-01-05 Apr 13, 2021
dmakarov pushed a commit that referenced this pull request Apr 13, 2021
@seanyoung @dmakarov
[SOL] Fixes required for Solang (#10)
eff1444 
* [SOL] Make lld thread-safe with llvm when used in-process

Every time Solang tries to link a web-assembly file in-process, the linker
re-inits llvm which is not thread-safe with the rest of solang.

Signed-off-by: Sean Young <sean@mess.org>

* [SOL][BPF] Enable the _ExtInt extension on the BPF Target for Solana

Signed-off-by: Sean Young <sean@mess.org>
dmakarov pushed a commit to dmakarov/llvm-project that referenced this pull request May 16, 2021
@seanyoung @dmakarov
[SOL] Fixes required for Solang (anza-xyz#10)
ed0e166 
* [SOL] Make lld thread-safe with llvm when used in-process

Every time Solang tries to link a web-assembly file in-process, the linker
re-inits llvm which is not thread-safe with the rest of solang.

Signed-off-by: Sean Young <sean@mess.org>

* [SOL][BPF] Enable the _ExtInt extension on the BPF Target for Solana

Signed-off-by: Sean Young <sean@mess.org>
@OluAgunloye OluAgunloye mentioned this pull request Sep 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmakarov dmakarov dmakarov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seanyoung @dmakarov