Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Github Actions #2

Merged

Conversation

Lichtso
Copy link

@Lichtso Lichtso commented Feb 4, 2021

master => main

@Lichtso Lichtso added the bug Something isn't working label Feb 4, 2021
@dmakarov
Copy link
Collaborator

dmakarov commented Feb 4, 2021

Some of the BPF test failures may be regressions. I'm checking them. Others are expected for solana-labs/llvm-project, e.g. many_args?.ll tests are not expected to compile by non-modified BPF backend, but compile by solana-labs llvm, because the extra args are passed on the stack.

I wonder if we can customize the workflow files to exclude irrelevant targets like AMDGPU, and maybe we should disable testing on Windows. The failure to build on macOS would also be resolved by disabling lldb project.

@dmakarov dmakarov force-pushed the solana-rustc/10.0-2020-05-05-fix-ci branch from b90124e to 86d16c5 Compare February 5, 2021 11:29
@dmakarov dmakarov force-pushed the solana-rustc/10.0-2020-05-05-fix-ci branch from 86d16c5 to b9ca222 Compare February 5, 2021 14:34
@dmakarov
Copy link
Collaborator

dmakarov commented Feb 5, 2021

@Lichtso: I'd like to merge this PR. The workflows now fail only on BPF tests, which I'll fix in the next PR.

@Lichtso
Copy link
Author

Lichtso commented Feb 5, 2021

Lets wait for them to run through one last time, and then I will merge it.

@Lichtso Lichtso merged commit 74bf690 into solana-rustc/10.0-2020-05-05 Feb 5, 2021
@dmakarov dmakarov deleted the solana-rustc/10.0-2020-05-05-fix-ci branch February 5, 2021 17:53
dmakarov added a commit to dmakarov/llvm-project that referenced this pull request Feb 26, 2021
* In Github actions: master => main

* Customize enabled projects and targets for llvm in github workflows

Co-authored-by: Dmitri Makarov <dmakarov@alumni.stanford.edu>
dmakarov added a commit to dmakarov/llvm-project that referenced this pull request May 16, 2021
* In Github actions: master => main

* Customize enabled projects and targets for llvm in github workflows

Co-authored-by: Dmitri Makarov <dmakarov@alumni.stanford.edu>
dmakarov added a commit to dmakarov/llvm-project that referenced this pull request Oct 28, 2021
* In Github actions: master => main

* Customize enabled projects and targets for llvm in github workflows

Co-authored-by: Dmitri Makarov <dmakarov@alumni.stanford.edu>
dmakarov added a commit to dmakarov/llvm-project that referenced this pull request Feb 28, 2022
* In Github actions: master => main

* Customize enabled projects and targets for llvm in github workflows

Co-authored-by: Dmitri Makarov <dmakarov@alumni.stanford.edu>
dmakarov added a commit to dmakarov/llvm-project that referenced this pull request Jul 18, 2022
* In Github actions: master => main

* Customize enabled projects and targets for llvm in github workflows

Co-authored-by: Dmitri Makarov <dmakarov@alumni.stanford.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants