Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix next warnings when building starter project #765

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

mikemaccana
Copy link
Contributor

Fix most next warnings when building starter project:

  • next-compose-plugins is no longer maintained so get along without it.
  • There's one remaining error re: modifyVars but add a link to the upstream issue.
  • Use variables for the colors rather than magic numbers.

@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2023

🦋 Changeset detected

Latest commit: ee7c65e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solana/wallet-adapter-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

🚮 Removed packages: next-compose-plugins@2.2.1

@mikemaccana
Copy link
Contributor Author

I've added a changeset as instructed.

Copy link
Collaborator

@jordaaash jordaaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.changeset/thick-tomatoes-pretend.md Outdated Show resolved Hide resolved
@jordaaash jordaaash merged commit 3b93799 into anza-xyz:master Apr 10, 2023
@mikemaccana
Copy link
Contributor Author

Thanks! Check out #761 when you get a sec too, I’ve scaled it way back so it should hopefully be more usable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants