Skip to content

Commit

Permalink
Coercion throws UncheckedIOException instead of IOException
Browse files Browse the repository at this point in the history
for methods that are not specifically I/O-related.
  • Loading branch information
ao-apps committed Oct 6, 2023
1 parent fdbfd50 commit 3c2b5c8
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 10 deletions.
8 changes: 4 additions & 4 deletions book/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ along with pragmatickm-password-taglib. If not, see <https://www.gnu.org/licens
<relativePath>../../../parent/pom.xml</relativePath>
</parent>

<groupId>com.pragmatickm</groupId><artifactId>pragmatickm-password-taglib-book</artifactId><version>1.8.1-POST-SNAPSHOT</version>
<groupId>com.pragmatickm</groupId><artifactId>pragmatickm-password-taglib-book</artifactId><version>1.9.0-SNAPSHOT</version>
<packaging>jar</packaging>

<properties>
Expand Down Expand Up @@ -145,7 +145,7 @@ along with pragmatickm-password-taglib. If not, see <https://www.gnu.org/licens
<configuration>
<artifactItems>
<artifactItem>
<groupId>com.pragmatickm</groupId><artifactId>pragmatickm-password-taglib</artifactId><version>1.8.1${POST-SNAPSHOT}</version>
<groupId>com.pragmatickm</groupId><artifactId>pragmatickm-password-taglib</artifactId><version>1.9.0-SNAPSHOT<!-- ${POST-SNAPSHOT} --></version>
<type>jar</type>
<includes>META-INF/pragmatickm-password.tld</includes>
</artifactItem>
Expand All @@ -155,7 +155,7 @@ along with pragmatickm-password-taglib. If not, see <https://www.gnu.org/licens
</executions>
<dependencies>
<dependency>
<groupId>com.pragmatickm</groupId><artifactId>pragmatickm-password-taglib</artifactId><version>1.8.1${POST-SNAPSHOT}</version>
<groupId>com.pragmatickm</groupId><artifactId>pragmatickm-password-taglib</artifactId><version>1.9.0-SNAPSHOT<!-- ${POST-SNAPSHOT} --></version>
<type>jar</type>
<exclusions><exclusion><groupId>*</groupId><artifactId>*</artifactId></exclusion></exclusions>
</dependency>
Expand Down Expand Up @@ -242,7 +242,7 @@ along with pragmatickm-password-taglib. If not, see <https://www.gnu.org/licens
<groupId>com.semanticcms</groupId><artifactId>semanticcms-core-taglib</artifactId><version>1.16.0-SNAPSHOT<!-- ${POST-SNAPSHOT} --></version>
</dependency>
<dependency>
<groupId>com.semanticcms</groupId><artifactId>semanticcms-section-taglib</artifactId><version>1.9.1${POST-SNAPSHOT}</version>
<groupId>com.semanticcms</groupId><artifactId>semanticcms-section-taglib</artifactId><version>1.10.0-SNAPSHOT<!-- ${POST-SNAPSHOT} --></version>
</dependency>
<dependency>
<groupId>com.semanticcms</groupId><artifactId>semanticcms-tag-reference</artifactId><version>1.10.1${POST-SNAPSHOT}</version>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ along with pragmatickm-password-taglib. If not, see <https://www.gnu.org/licens
shortTitle="Changelog"
tocLevels="1"
datePublished="2017-07-25T20:56:44-05:00"
dateModified="2022-05-15T19:16:45-05:00"
dateModified="2023-10-06T05:56:05Z"
>
<c:set var="latestRelease" value="1.8.1" />
<c:if test="${
Expand All @@ -52,7 +52,11 @@ along with pragmatickm-password-taglib. If not, see <https://www.gnu.org/licens
artifactId="@{documented.artifactId}"
repository="@{nexusUrl}content/repositories/snapshots/"
scmUrl="@{project.scm.url}"
/>
>
<ul>
<li><code>ElementTag.evaluateAttributes(…)</code> no longer throws <code>IOException</code>.</li>
</ul>
</changelog:release>
</c:if>

<changelog:release
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ along with pragmatickm-password-taglib. If not, see <https://www.gnu.org/licens
<relativePath>../../parent/pom.xml</relativePath>
</parent>

<groupId>com.pragmatickm</groupId><artifactId>pragmatickm-password-taglib</artifactId><version>1.8.1-POST-SNAPSHOT</version>
<groupId>com.pragmatickm</groupId><artifactId>pragmatickm-password-taglib</artifactId><version>1.9.0-SNAPSHOT</version>
<packaging>jar</packaging>

<properties>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ protected PasswordTable createElement() {
}

@Override
protected void evaluateAttributes(PasswordTable element, ELContext elContext) throws JspTagException, IOException {
protected void evaluateAttributes(PasswordTable element, ELContext elContext) throws JspTagException {
super.evaluateAttributes(element, elContext);
element.setHeader(resolveValue(header, String.class, elContext));
}
Expand All @@ -97,7 +97,7 @@ protected void doBody(PasswordTable passwordTable, CaptureLevel captureLevel) th
// Evaluate expressins
@SuppressWarnings("unchecked")
Iterable<? extends Password> passwordIter = resolveValue(passwords, Iterable.class, elContext);
Object styleObj = Coercion.nullIfEmpty(resolveValue(style, Object.class, elContext));
Object styleObj = Coercion.nullIfEmpty(resolveValue(style, Object.class, elContext)); // TODO: ao-fluent-html-any normalize here and similar

BufferWriter capturedOut = EncodingBufferedTag.newBufferWriter(request);
try {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ protected Password createElement() {
}

@Override
protected void evaluateAttributes(Password pssword, ELContext elContext) throws JspTagException, IOException {
protected void evaluateAttributes(Password pssword, ELContext elContext) throws JspTagException {
super.evaluateAttributes(pssword, elContext);
pssword.setHref(resolveValue(href, String.class, elContext));
pssword.setUsername(resolveValue(username, String.class, elContext));
Expand Down

0 comments on commit 3c2b5c8

Please sign in to comment.