Skip to content
This repository has been archived by the owner on Jan 4, 2022. It is now read-only.

sql error when uploading events/detections with a station name containing apostrophe #9

Closed
jkburges opened this issue Sep 4, 2013 · 8 comments
Assignees
Labels

Comments

@jkburges
Copy link
Contributor

jkburges commented Sep 4, 2013

  1. Upload detection file which has station name containing apostrophe, e.g. http://aatams.emii.org.au/aatams/receiverDownloadFile/show/70615542 (spider's ledge)

A org.postgresql.util.PSQLException is thrown.

We should be escaping/quoting things properly.

@danfruehauf
Copy link
Contributor

http://xkcd.com/327/

@ghost ghost assigned danfruehauf Sep 24, 2013
@jkburges
Copy link
Contributor Author

@danfruehauf you tested your fix against the problematic file? Can this be closed?

@danfruehauf
Copy link
Contributor

AFAIK yes, however, link this to the new bug it introduced.

@jkburges
Copy link
Contributor Author

Closing, as @danfruehauf 's fix seems to have fixed this bug.
However, it may have introduced #29

@danfruehauf danfruehauf reopened this Nov 18, 2013
@jkburges
Copy link
Contributor Author

This is going to be handled as a backlog item.

@jkburges
Copy link
Contributor Author

@pblain I guess from my previous comment here that I've discussed this issue with you already, but just confirming, do we have a backlog item for this already?

I think we need to have a bit of a re-think about how we upload and store detections. We can probably solve this problem, as well as remove the need to refresh materialised views nightly (which uses a lot of CPU on the DB) and probably some other performance problems too. But, it's not trivial :-)

@pblain
Copy link

pblain commented Feb 19, 2014

Yes, there is a backlog item related to this (NET55). We'll need to flesh it out before it makes it to planning. But it's in there.

@jkburges
Copy link
Contributor Author

jkburges commented May 7, 2014

Noting that this is still an issue for users. Andrew has just emailed Rog about it.

@jkburges jkburges removed the triaged label Feb 3, 2015
@jkburges jkburges assigned jkburges and unassigned danfruehauf Feb 10, 2015
jkburges added a commit that referenced this issue Feb 11, 2015
Use JOOQ to construct SQL, which takes care of properly escaping values.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants