Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scoop installation instruction to Readme #263

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

rashil2000
Copy link
Contributor

spotify-player has been added to Scoop's Main repository: https://github.com/ScoopInstaller/Main/blob/master/bucket/spotify-player.json, making it super easy to install on Windows systems.

@rashil2000
Copy link
Contributor Author

On a related note, the daemon feature is a unix-only feature, and is not supported on Windows as such. I have modified the Readme to reflect that.

Should I also gate the daemon feature behind a [target.'cfg(target_os = "unix")'.dependencies] directive in the Cargo.toml?

@aome510
Copy link
Owner

aome510 commented Oct 2, 2023

Should I also gate the daemon feature behind a [target.'cfg(target_os = "unix")'.dependencies] directive in the Cargo.toml?

A readme note saying that the feature is not supported for Windows is fine. I'm not sure how well OS-based dependency and feature-based dependency will work together.

@aome510 aome510 merged commit d051d15 into aome510:master Oct 2, 2023
3 checks passed
@rashil2000 rashil2000 deleted the add-scoop branch October 2, 2023 18:36
@aome510 aome510 mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants