UI album year #305
Merged
UI album year #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aome510
reviewed
Dec 1, 2023
aome510
reviewed
Dec 1, 2023
aome510
reviewed
Dec 1, 2023
aome510
reviewed
Dec 1, 2023
Change comment Co-authored-by: Thang Pham <phamducthang1234@gmail.com>
aome510
approved these changes
Dec 6, 2023
|
Thanks for fixing the formatting & merging this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for developing spotify-player. I enjoy using it a lot. One thing that was nagging me was that the interface did not give me a sense of time when browsing an artist's page. I therefore added a config option to display the album names prefixed with the year.
As there was no issue mentioning this, I don't know if this implementation fits your ideas for spotify-player, just let me know if it doesn't. Also, my Rust is a bit rusty, so let me know if you have some suggestions before merging this.