handle title padding with hidden borders #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unable to test due to #349 |
|
Still unable to test even with rustup: |
oh right, I forgot. Make another branch w/o the upgrade change in https://github.com/aome510/spotify-player/tree/test-331. Can you check out that instead? |
|
Keep in mind i have changed the |
The only difference is title is aligned. As I already said, paddings are needed to avoid windows getting too close |
|
If this is the case it does not resolve my issue, which is the padding being present. Is it not possible to have a simple condition for if it is on the bottom..? |
Just to clarify, you're talking about the top padding right. There are two lines separating the playback windows and the above window and you probably want to reduce the top padding to be 1 line instead. This is not possible to implement w/o hacking because all windows are assumed to have all paddings to represent borders. |
|
Of course, it's possible to add conditions when the playback is in bottom and specify the paddings for the playback window accordingly. I don't want to do so because that will require to "patch" the code and make it more complicated and harder to reason about. |
Quite baffled by this because the TUI library itself should be the one calculating the paddings, and seeing it is on the bottom with no border, it shouldn't render a padding to begin with. |
The TUI library will not render any paddings if border is set to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch aligns the title with the inner text when in
Hiddenborder mode.