Remove winit from compilation on Linux #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Winit is only used in one line in MacOS and Windows, and unused in Linux. This change improves initial compile times from 3m 50s to ~3m 25 on my machine.
aome510
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Winit is only used in one line in MacOS and Windows, and unused in Linux.
This change improves from-scratch compile times from ~3m 47s to ~3m 25 on my Linux machine, as
winitwas in the critical chain of compilation.I attached the output of
cargo b --release --timingsin case you want to read them. GitHub does not allow uploading HTML files so they're zipped heretimings.zip
(BTW enjoy the vacation!)