Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for Win with local libyuv fails #1765

Closed
eddiezato opened this issue Nov 16, 2023 · 5 comments
Closed

Build for Win with local libyuv fails #1765

eddiezato opened this issue Nov 16, 2023 · 5 comments

Comments

@eddiezato
Copy link

CMake Error at CMakeLists.txt:140 (message):
  libavif(AVIF_LOCAL_LIBYUV):
  D:/msys2/home/Gautama/libavif/ext/libyuv/build/libyuv.dll is missing,
  bailing out

I fix this in my scripts by manually setting LIB_FILENAME to libyuv.a.

@vrabaud
Copy link
Collaborator

vrabaud commented Nov 16, 2023

Thx for reporting. Which compiler are you using ? MSVC/MINGW ? Can you please provide your command line? Thx!

@kmilos
Copy link
Contributor

kmilos commented Nov 16, 2023

That's stange, as according to this:

set(LIB_FILENAME "${AVIF_LIBYUV_BUILD_DIR}/${AVIF_LIBRARY_PREFIX}yuv${CMAKE_STATIC_LIBRARY_SUFFIX}")

and this

https://gitlab.kitware.com/cmake/cmake/-/blob/572f3105c1a011854c29d7764d5c89312c0c8932/Modules/Platform/Windows-GNU.cmake#L41

it should already be looking for libyuv.a?

@eddiezato
Copy link
Author

Compiler: Clang
Environment: MSYS2 / Clang64 and UCRT64

There is a workaround for dav1d c947c7d.

@eddiezato
Copy link
Author

@kmilos for v1.0.1

set(LIB_FILENAME "${CMAKE_CURRENT_SOURCE_DIR}/ext/libyuv/build/${AVIF_LIBRARY_PREFIX}yuv${AVIF_LIBRARY_SUFFIX}")

I guess this has been fixed afterward.

@eddiezato
Copy link
Author

Sorry, I should've checked in main. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants