Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only require customLegendElement #120

Merged
merged 1 commit into from Jul 17, 2020
Merged

Conversation

RobbieTheWagner
Copy link
Collaborator

@RobbieTheWagner RobbieTheWagner commented Jul 17, 2020

This fixes an issue where you could use the built in generateLabels, and might not be supplying the legendCallback.

@aomran
Copy link
Owner

aomran commented Jul 17, 2020

@rwwagner90 can I add you as a maintainer on https://www.npmjs.com/ so you can publish versions?

@RobbieTheWagner
Copy link
Collaborator Author

@aomran please feel free to add me on npm 👍

@RobbieTheWagner RobbieTheWagner merged commit cca9568 into master Jul 17, 2020
@RobbieTheWagner RobbieTheWagner deleted the rwwagner90-patch-1 branch July 17, 2020 17:08
@aomran
Copy link
Owner

aomran commented Jul 17, 2020

@rwwagner90 ok, I added you, feel free to bump the version and publish whenever you like. I did a version bump recently to get the dependencies upgraded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants