Fix opennav_docking error_msg/code usage (ros-navigation#4341)

Signed-off-by: Mike Wake <michael.wake@aosgrp.com.au>
aosmw · Jun 26, 2024 · bd49b55 · bd49b55
1 parent 81db3a0
commit bd49b55
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/nav2_docking/opennav_docking/src/docking_server.cpp b/nav2_docking/opennav_docking/src/docking_server.cpp
@@ -337,6 +337,7 @@ void DockingServer::dockRobot()
   } catch (opennav_docking_core::DockingException & e) {
     result->error_msg = e.what();
     RCLCPP_ERROR(get_logger(), result->error_msg.c_str());
+    result->error_code = DockRobot::Result::UNKNOWN;
   } catch (std::exception & e) {
     result->error_code = DockRobot::Result::UNKNOWN;
     result->error_msg = e.what();

diff --git a/nav2_docking/opennav_docking/test/test_docking_server.py b/nav2_docking/opennav_docking/test/test_docking_server.py
@@ -136,7 +136,7 @@ def nav_execute_callback(self, goal_handle):
 
         result = NavigateToPose.Result()
         result.error_code = 0
-        result.error_msg = ""
+        result.error_msg = ''
         return result
 
     def test_docking_server(self):